Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made updates to permit project and tracker pages #217

Closed
wants to merge 1 commit into from

Conversation

qhanson55
Copy link
Contributor

@qhanson55 qhanson55 commented Dec 12, 2024

Description

Made UI updates to the Permit tracker and project views/pages. Also made it so that confirmation emails are going out when making an enquiry to a Navigator and add UI changes.
Changes made to match feedback and UI/UX design
PAD-391

Types of changes

UI Update

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

github-actions bot commented Dec 12, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 24.77% ( 1673 / 6754 )
Methods: 20.7% ( 237 / 1145 )
Lines: 29.34% ( 981 / 3344 )
Branches: 20.09% ( 455 / 2265 )

Copy link

Coverage Report (Application)

Totals Coverage
Statements: 36.25% ( 1047 / 2888 )
Methods: 24.6% ( 123 / 500 )
Lines: 47.55% ( 698 / 1468 )
Branches: 24.57% ( 226 / 920 )

@slhurley
Copy link
Collaborator

slhurley commented Dec 12, 2024

✓ When a permit is entered on the intake form as needed but no one has yet verified the status (it is auto set to In Progress)...on the tracker it says "This status was last verified by Quinn Hanson"....(and then switched to Naixin) but you have not touched the permit at all. See project "PR-217 test". Updated By on the Nav permit tab is blank so it seems to be randomly choosing names.

@qhanson55 qhanson55 force-pushed the chore/update-permit-tracker branch from 8892094 to 0345c29 Compare December 12, 2024 23:53
@naixin-zhangbc
Copy link

naixin-zhangbc commented Dec 13, 2024

Tested this views by submitting intake forms from Proponents side. All functions are working well! Just some CSS changes needed.

The tracker page:
The box with Tracking ID, Submitted date, Permit ID, etc.: Reduce the spacing above the Tracking ID line to 32px.
Button "What does the status mean?: Align the font colour with the blue of the question mark icon.
✓ (made it H4 which is 24px) Headers of "Application progress" and "Additional updates: In our Figma file H3 is 22px. Apparently it's different in the dev library. Could you please replace it with a header that's close to 22px?
The dotted line circle used in the tracker Could you please change its colour to 9F9D9C?
Alignment: Increase the spacing to the left of the header "Application progress", the tracker bar and the "This status is last verified..." text to left-align them with the status pill
✓ Change the text next to the Ask my Navigator button to "Contact your Navigator for this project for further updates on this application."

The two Ask my Navigator modals:
✓ Increase the spacing between the To: line and the message box to 8px.

Additionally, Sharolyn mentioned a concern from the user related to the placement of the latest updates on the tracker page. I'll need to play around with the design further, and show it to you and see if we have time to address it. Otherwise we'll leave it for future improvements.

@qhanson55 qhanson55 force-pushed the chore/update-permit-tracker branch from 0345c29 to 454164b Compare December 13, 2024 00:29
@qhanson55
Copy link
Contributor Author

Fixed UI/UX comments from Naixin and fixed Sharolyn's comment/bug showing a random user when there is no "updatedBy" value.

@qhanson55 qhanson55 force-pushed the chore/update-permit-tracker branch from 454164b to 39eb65d Compare December 13, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants