Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update home page with initiative links, add back button to individual submission page #22

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

wilwong89
Copy link
Collaborator

Description

Remove placeholder Vue links
Directly display initiatives selection on the homepage, with greyed out button when not logged in.
Added back button to individual submissions to go back to submissions list page

Files changed:
Navbar.vue
HomeView.vue
SubmissionVue.vue

Types of changes

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

Coverage Report (Application)

Totals Coverage
Statements: 43.57% ( 61 / 140 )
Methods: 26.32% ( 5 / 19 )
Lines: 60.76% ( 48 / 79 )
Branches: 19.05% ( 8 / 42 )

Copy link

github-actions bot commented Jan 25, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 36.82% ( 211 / 573 )
Methods: 35.14% ( 39 / 111 )
Lines: 42.59% ( 135 / 317 )
Branches: 25.52% ( 37 / 145 )

@kyle1morel
Copy link
Collaborator

I would double check with Tyler about the UI for the home view. The ticket calls for the initiative text and button to be centered, but I think that may look odd.

@tpantella
Copy link

tpantella commented Jan 26, 2024

Please center "Choose an Initiative" and have the button centered - for now this change will be visually pleasing and appropriate, though as the content grows we may want to reconsider left alignment in the future. Please use the original text specified in the JIRA ticket "Welcome to the PermitConnect Applications" but with no punctuation (no ellipses, no !, no ). - this will match some of the standards set for page titling and the standard we set with BCBox's homepage.

Otherwise looks good.

@wilwong89 wilwong89 force-pushed the feat/homepage-change branch from cfba26f to 0d56bcd Compare January 29, 2024 17:49
Copy link

codeclimate bot commented Jan 29, 2024

Code Climate has analyzed commit fe04181 and detected 0 issues on this pull request.

View more on Code Climate.

@wilwong89 wilwong89 force-pushed the feat/homepage-change branch from 0d56bcd to fe04181 Compare January 29, 2024 18:02
@kyle1morel kyle1morel merged commit de86f81 into master Jan 29, 2024
19 of 20 checks passed
@kyle1morel kyle1morel deleted the feat/homepage-change branch January 29, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants