feat: Add submittions types to data model, types, and frontend, update intake state and activity status #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed enums and const util files to reflect new statuses Made SubmissionsForm default activity state to 'New'. modified: frontend/src/components/form/Dropdown.vue modified: frontend/src/components/submission/SubmissionForm.vue modified: frontend/src/utils/constants.ts modified: frontend/src/utils/enums.ts
|
Code Climate has analyzed commit b0afeb9 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Coverage Report (Application)
|
Coverage Report (Frontend)
|
wilwong89
requested review from
jujaga,
norrisng-bc,
TimCsaky,
jatindersingh93 and
kyle1morel
as code owners
kyle1morel
reviewed
Feb 1, 2024
kyle1morel
reviewed
Feb 1, 2024
kyle1morel
reviewed
Feb 1, 2024
kyle1morel
reviewed
Feb 1, 2024
…submissionTypes logic
wilwong89
force-pushed
the
feat/submission-types
branch
from
1daec71 to
b0afeb9
Compare
kyle1morel
approved these changes
Feb 2, 2024
|
Preemptively approving - approved once the 500 on Submission load is fixed. |
TimCsaky
reviewed
Feb 5, 2024
| @@ -65,7 +66,12 @@ export default { | |||
| notes: input.notes, | |||
| user: input.user?.userId ? { connect: { userId: input.user.userId } } : disconnectRelation, | |||
| intakeStatus: input.intakeStatus, | |||
| applicationStatus: input.applicationStatus | |||
| applicationStatus: input.applicationStatus, | |||
| guidance: input.guidance ? input.guidance : false, | |||
There was a problem hiding this comment.
cant these just be guidance: input.guidance
the db field defaults to false.. the html form can submit false
| @@ -39,9 +40,19 @@ const assigneeOptions: Ref<Array<User>> = ref([props.submission.user]); | |||
| // Default form values | |||
| const initialFormValues: any = { | |||
| ...props.submission, | |||
| applicationStatus: props.submission.applicationStatus | |||
| ? props.submission.applicationStatus | |||
| : APPLICATION_STATUS_LIST.NEW, | |||
There was a problem hiding this comment.
i think this can be removed now that youre adding NEW during chefs data import(?)
TimCsaky
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated intake state and activity status values to title case from uppercase
Added new activity status "New"
Set default activity state to "New" on edit on frontend
Added new submission types to data model and types
Make frontend changes to allow editing new submission types
Added validation to frontend for submission types
Added new value "bcOnlineCompleted" to data model
Added checkbox for BC Online Completed to frontend
Types of changes
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Checklist
Further comments