Rewrite getConfig to attempt to reacquire config if missing #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this does not solve latent navigation issues when they show up because getConfig must remain a synchronous function, this does allow the application to attempt to recover should the user try further navigation actions after it finds the configuration is somehow missing from session storage. Signed-off-by: Jeremy Ho <jujaga@gmail.com>
jujaga
requested review from
norrisng-bc,
TimCsaky,
jatindersingh93,
kyle1morel and
wilwong89
as code owners
Coverage Report (Application)
|
Coverage Report (Frontend)
|
|
Code Climate has analyzed commit c974485 and detected 0 issues on this pull request. View more on Code Climate. |
jatindersingh93
approved these changes
Feb 21, 2024
kyle1morel
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While this does not solve latent navigation issues when they show up because getConfig must remain a synchronous function, this does allow the application to attempt to recover should the user try further navigation actions after it finds the configuration is somehow missing from session storage.
SHOWCASE-3533
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
Further comments