Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional handling for email delimiters in roadmap feature #71

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

wilwong89
Copy link
Collaborator

@wilwong89 wilwong89 commented Apr 25, 2024

Description

Enable roadmap email fields to handle space, comma, and semi-colon as delimiters

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Ticket: PADS-2

Copy link

Coverage Report (Application)

Totals Coverage
Statements: 47.66% ( 539 / 1131 )
Methods: 37.44% ( 85 / 227 )
Lines: 60.74% ( 362 / 596 )
Branches: 29.87% ( 92 / 308 )

Copy link

github-actions bot commented Apr 25, 2024

Coverage Report (Frontend)

Totals Coverage
Statements: 24.42% ( 533 / 2183 )
Methods: 22.06% ( 90 / 408 )
Lines: 27.33% ( 329 / 1204 )
Branches: 19.96% ( 114 / 571 )

Copy link

codeclimate bot commented Apr 25, 2024

Code Climate has analyzed commit 387781d and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 3

The test coverage on the diff in this pull request is 66.6% (50% is the threshold).

This pull request will bring the total coverage in the repository to 38.3% (0.3% change).

View more on Code Climate.

@wilwong89 wilwong89 force-pushed the fix/email-delimiters branch 2 times, most recently from ebe6593 to 547da93 Compare April 26, 2024 01:00
@wilwong89 wilwong89 marked this pull request as ready for review April 26, 2024 01:04
@wilwong89 wilwong89 requested a review from kyle1morel as a code owner April 26, 2024 01:04
@wilwong89 wilwong89 force-pushed the fix/email-delimiters branch from 547da93 to 387781d Compare April 26, 2024 01:05
@kyle1morel kyle1morel merged commit 5d669e3 into master Apr 29, 2024
20 of 22 checks passed
@kyle1morel kyle1morel deleted the fix/email-delimiters branch April 29, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants