Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow saving and updating of intake drafts #77

Merged
merged 3 commits into from
May 21, 2024

Conversation

kyle1morel
Copy link
Collaborator

Description

Improves the current SHAS intake form to allow the saving and updating of draft versions of the form.

Types of changes

New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@kyle1morel kyle1morel requested a review from wilwong89 as a code owner May 15, 2024 20:33
Copy link

Coverage Report (Application)

Totals Coverage
Statements: 50.12% ( 646 / 1289 )
Methods: 40.93% ( 106 / 259 )
Lines: 61.98% ( 414 / 668 )
Branches: 34.81% ( 126 / 362 )

Copy link

Coverage Report (Frontend)

Totals Coverage
Statements: 21.21% ( 574 / 2706 )
Methods: 18.4% ( 94 / 511 )
Lines: 24.28% ( 360 / 1483 )
Branches: 16.85% ( 120 / 712 )

@kyle1morel kyle1morel force-pushed the feature/intake-form-draft branch from 33ef9b4 to 13294e5 Compare May 15, 2024 20:41
Bug noticed by navs where backspacing caused the whitespace to be removed automatically
@kyle1morel kyle1morel requested a review from sanjaytkbabu May 16, 2024 19:25
Slipstream update
housing = {
projectName: data.housing.projectName,
projectDescription: data.housing.projectDescription,
//singleFamilySelected: true, // not necessary to save - check if singleFamilyUnits not null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider getting rid of comments if not required.

@kyle1morel kyle1morel merged commit 9b94430 into feature/intake-form May 21, 2024
16 of 17 checks passed
@kyle1morel kyle1morel deleted the feature/intake-form-draft branch May 21, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants