SHAS Enquiry form #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report (Frontend)
|
|
I'm not sure if this is the right PR but reminder to yank the enquiry type from the Enquiry form but also to add the Enquiry text field to the Note that is created on the related submission. |
kyle1morel
force-pushed
the
feature/enquiry
branch
2 times, most recently
from
545b0be to
9e3f976
Compare
Coverage Report (Application)
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit 56d6e60 and detected 43 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 54.3% (50% is the threshold). This pull request will bring the total coverage in the repository to 43.0% (5.5% change). View more on Code Climate. |
kyle1morel
force-pushed
the
feature/enquiry
branch
from
9e3f976 to
7b1d2a9
Compare
kyle1morel
force-pushed
the
feature/enquiry
branch
from
7b1d2a9 to
56d6e60
Compare
kyle1morel
force-pushed
the
feature/enquiry
branch
from
56d6e60 to
2f93504
Compare
wilwong89
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the form functionality for the new SHAS enquiry form. Allows full submission and draft saving. If enquiry is marked as related a new note will be created in the related submission. If enquiry is marked as wanting to apply, a new submission will automatically be created and added as related to the enquiry.
Types of changes
New feature (non-breaking change which adds functionality)
Checklist
Further comments