Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign a user to submission #9

Merged
merged 8 commits into from
Dec 21, 2023
Merged

Assign a user to submission #9

merged 8 commits into from
Dec 21, 2023

Conversation

kyle1morel
Copy link
Collaborator

@kyle1morel kyle1morel commented Dec 20, 2023

Description

Implements the User service to automatically create/update users in the database as they log in.
Updates the Helmet content security policy.
Changes the application name across the board to the new one.
Implements assigning of a user to a submission.
Implements a to/from DB model to correctly convert objects from Prisma to app usable objects and vice versa.

Types of changes

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

Coverage Report (Frontend)

Totals Coverage
Statements: 46.74% ( 179 / 383 )
Methods: 45.57% ( 36 / 79 )
Lines: 51.36% ( 113 / 220 )
Branches: 35.71% ( 30 / 84 )

Additionally moves the database towards a logical/physical model approach
More closely resembles the generated Prisma schema
app/src/controllers/chefs.ts Outdated Show resolved Hide resolved
app/src/db/models/submission.ts Show resolved Hide resolved
app/src/db/models/disconnectRelation.ts Outdated Show resolved Hide resolved
app/src/types/User.ts Show resolved Hide resolved
frontend/src/components/submission/SubmissionForm.vue Outdated Show resolved Hide resolved
Copy link

Coverage Report (Application)

Totals Coverage
Statements: 41.45% ( 63 / 152 )
Methods: 23.81% ( 5 / 21 )
Lines: 59.52% ( 50 / 84 )
Branches: 17.02% ( 8 / 47 )

app/src/components/utils.ts Dismissed Show dismissed Hide dismissed
app/src/components/utils.ts Dismissed Show dismissed Hide dismissed
app/src/components/utils.ts Dismissed Show dismissed Hide dismissed
app/src/components/utils.ts Dismissed Show dismissed Hide dismissed
app/src/components/utils.ts Dismissed Show dismissed Hide dismissed
app/src/components/utils.ts Dismissed Show dismissed Hide dismissed
@norrisng-bc norrisng-bc merged commit 900fee1 into master Dec 21, 2023
17 of 19 checks passed
@norrisng-bc norrisng-bc deleted the feature/assign branch December 21, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants