Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/core schema minor #17

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Fix/core schema minor #17

merged 2 commits into from
Jul 2, 2024

Conversation

annikaLiving
Copy link
Contributor

Added

  • West Coast as an enum

Changed

  • the state attribute name and values
  • the status values

@annikaLiving annikaLiving requested a review from JTA2020 July 2, 2024 20:33
Copy link
Contributor

@JTA2020 JTA2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why we are deleting "Suspended" in applicaiton_lifecycle_state @annikaLiving

@annikaLiving
Copy link
Contributor Author

annikaLiving commented Jul 2, 2024

@JTA2020 suspended was removed as On Hold existed and Suspended could mean On Hold in the process, or an issued permit could be suspended after approval for any number of reasons. feels ambiguous. more work with come on states and statuses as we compile our research. Then developing the data dictionary for all of these terms.

Copy link
Contributor

@JTA2020 JTA2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for elaborating

@annikaLiving annikaLiving merged commit c468bc9 into main Jul 2, 2024
4 checks passed
@annikaLiving annikaLiving deleted the fix/core-schema-minor branch July 2, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants