Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SRS-681: Add Map showing the specific location for the site id on Summary tab #233

Merged
merged 9 commits into from
Dec 12, 2024

Conversation

nupurdixit13
Copy link
Contributor

@nupurdixit13 nupurdixit13 commented Dec 11, 2024

Description

This ticket is to show the map with the exact location of the site Id in the location section on Summary tab.
The designs have been validated by Harry. Pinch and zoom functionality is available.

Attaching demo for reference.

LOcation_Summary_PR_Demo.mov

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@nupurdixit13 nupurdixit13 requested a review from a team as a code owner December 11, 2024 22:45
Copy link
Contributor

@nikhila-aot nikhila-aot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build is failing, pls take a look

Copy link
Contributor

@anton-bcgov anton-bcgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not mentioning this in my original review, but I just took another look at this PR and had more thoughts.

Additionally, the SummaryInfo file has unused imports, could you clean those up as well?

frontend/src/app/features/details/summary/SummaryInfo.tsx Outdated Show resolved Hide resolved
frontend/src/app/features/details/summary/SummaryInfo.tsx Outdated Show resolved Hide resolved
frontend/src/app/features/details/summary/SummaryInfo.tsx Outdated Show resolved Hide resolved
@nupurdixit13
Copy link
Contributor Author

Sorry for not mentioning this in my original review, but I just took another look at this PR and had more thoughts.

Additionally, the SummaryInfo file has unused imports, could you clean those up as well?

Yeah will take care of the same

@nupurdixit13
Copy link
Contributor Author

The build is failing, pls take a look

Fixed, thanks

Copy link
Contributor

@anton-bcgov anton-bcgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for taking care of the comments

@nupurdixit13 nupurdixit13 requested review from jaspalsingh-aot and removed request for jaspalsingh-aot December 12, 2024 20:32
@nupurdixit13 nupurdixit13 merged commit e00a8ba into dev Dec 12, 2024
15 checks passed
@nupurdixit13 nupurdixit13 deleted the linkMap branch December 12, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants