fix: Fix Authorization header value for unauthenticated users #247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix Authorization header value for unauthenticated users
Before:
Bearer undefined
After:
Bearer
Why this is important
Before, on every unauthenticated request Keycloak was trying to decode the string
"undefined"
as a valid token and, of course, failed every time and never passed the AuthGuard.When the token is empty, Keycloak skips the decoding part. In turn, this lets us set up public routes/queries like this:
This means we can reuse the same query for both authenticated and unauthenticated experiences, but change how they are processed by the service. More context here
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: