Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 1807 backend tests cypress #1811

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ngunner15
Copy link
Collaborator

@ngunner15 ngunner15 commented Jan 13, 2025

Description

Closes #1807

Changelog

New

  • API test(200, 201 and 404)

Changed

Removed

  • None

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@ngunner15 ngunner15 linked an issue Jan 13, 2025 that may be closed by this pull request
2 tasks
@ngunner15 ngunner15 self-assigned this Jan 13, 2025
@ngunner15 ngunner15 added back-end back-end related task test test related task labels Jan 13, 2025
@ngunner15 ngunner15 marked this pull request as ready for review January 13, 2025 23:37
Copy link
Collaborator

@mgaseta mgaseta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!
Added only one question, after we solve that it's good to go!

@@ -1,3 +1,4 @@
/* eslint-disable no-loop-func */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the documentation of this rule, it seems quite critical, why do we need to disable it?
https://eslint.org/docs/latest/rules/no-loop-func

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end back-end related task test test related task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add backend tests in Cypress
2 participants