Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 1740 inaccurate data being shown in review form #1814

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

mgaseta
Copy link
Collaborator

@mgaseta mgaseta commented Jan 15, 2025

Description

Closes #1740

Changelog

New

  • Nothing :)

Changed

  • The title of the section
  • Made a small adjustments on favourites columns
  • Where the data is coming from to set the payload after user triggers a recalculation

Removed

  • Nothing :)

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@mgaseta mgaseta requested a review from ngunner15 January 15, 2025 17:53
@mgaseta mgaseta self-assigned this Jan 15, 2025
@mgaseta mgaseta linked an issue Jan 15, 2025 that may be closed by this pull request
Copy link
Collaborator

@ngunner15 ngunner15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mgaseta mgaseta merged commit 5c3e341 into main Jan 16, 2025
29 checks passed
@mgaseta mgaseta deleted the fix/1740-inaccurate-data-being-shown-in-review-form branch January 16, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inaccurate data being shown in review form
3 participants