Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview the template doc #143

Merged
merged 3 commits into from
Mar 29, 2024
Merged

Preview the template doc #143

merged 3 commits into from
Mar 29, 2024

Conversation

ssmumbai07
Copy link
Collaborator

Description

Please provide a summary of the change and the issue fixed. Please include relevant context. List dependency changes.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • I have read the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have already been accepted and merged

Further comments

Copy link
Collaborator

@mgtennant mgtennant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was looking at the functionality and it seems that it's losing all of the formatting when the document is generated.

It might be better to have cdogs convert the template to a pdf and then display that instead which should preserve the formatting.

Merging this for now but it should be improved in the future.

@mgtennant mgtennant merged commit 7b77d26 into main Mar 29, 2024
2 of 5 checks passed
@mgtennant mgtennant deleted the TICDI-324_Preview branch March 29, 2024 23:58
@barrfalk
Copy link
Collaborator

Your Pull Request code is being promoted! Please follow the link below.

Main Merge Workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants