Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add a way to delete persisted secrets when pr is closed as helm wont delete persisted secrets. #90

Closed
wants to merge 3 commits into from

Conversation

mishraomp
Copy link
Contributor

@mishraomp mishraomp commented Oct 11, 2024

Also added a small change to remove pvc after pr close.

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@mishraomp
Copy link
Contributor Author

close to test

@mishraomp mishraomp closed this Oct 11, 2024
@mishraomp mishraomp reopened this Oct 11, 2024
@mishraomp
Copy link
Contributor Author

close to test

@mishraomp mishraomp closed this Oct 11, 2024
@mishraomp mishraomp reopened this Oct 11, 2024
@mishraomp mishraomp changed the title chore: add a way to delete persisted secrets when is pr is closed as helm wont delete persisted secrets. chore: add a way to delete persisted secrets when pr is closed as helm wont delete persisted secrets. Oct 12, 2024
@mishraomp
Copy link
Contributor Author

not required, closing

@mishraomp mishraomp closed this Nov 13, 2024
@mishraomp mishraomp deleted the fix/delete-persisted-secrets-pr-env branch November 13, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant