New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS & security fixes #10

Merged

jujaga merged 2 commits into master from bugfix/css

Dec 18, 2023

Contributor

kyle1morel commented Dec 18, 2023

Description

Backports two fixes to the scaffold.

Aligns filled and outline button sizes
Resolves an issue with Helmet preventing logins

Types of changes

Checklist

I have read the CONTRIBUTING doc
I have checked that unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

Further comments


          Ensure primary and outlined buttons are same size

91127b7

kyle1morel requested review from jujaga, norrisng-bc, TimCsaky, jatindersingh93 and wilwong89 as code owners

December 18, 2023 16:15

github-actions bot commented Dec 18, 2023

Coverage Report (Application)

Totals
Statements:	70.67% ( 53 / 75 )
Methods:	62.5% ( 5 / 8 )
Lines:	81.63% ( 40 / 49 )
Branches:	44.44% ( 8 / 18 )

github-actions bot commented Dec 18, 2023

Coverage Report (Frontend)

Totals
Statements:	50.6% ( 169 / 334 )
Methods:	50% ( 37 / 74 )
Lines:	55.67% ( 108 / 194 )
Branches:	36.36% ( 24 / 66 )

wilwong89 approved these changes

View reviewed changes


          Update Helmet content security policy

0feafd9

kyle1morel force-pushed the bugfix/css branch from 3e3b04e to 0feafd9 Compare

December 18, 2023 17:59

jujaga approved these changes

View reviewed changes

jujaga merged commit 3e512cd into master

18 of 19 checks passed

jujaga deleted the bugfix/css branch

December 18, 2023 18:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

wilwong89 wilwong89 approved these changes

jujaga jujaga approved these changes

norrisng-bc Awaiting requested review from norrisng-bc norrisng-bc is a code owner

TimCsaky Awaiting requested review from TimCsaky TimCsaky is a code owner

jatindersingh93 Awaiting requested review from jatindersingh93 jatindersingh93 is a code owner

Labels

None yet