Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create explicit docker stage for app build #13

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Create explicit docker stage for app build #13

merged 1 commit into from
Dec 22, 2023

Conversation

jujaga
Copy link
Member

@jujaga jujaga commented Dec 22, 2023

Description

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the CONTRIBUTING doc
  • I have checked that unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@jujaga jujaga added the bug Something isn't working label Dec 22, 2023
@jujaga jujaga self-assigned this Dec 22, 2023
Copy link

Coverage Report (Application)

Totals Coverage
Statements: 70.67% ( 53 / 75 )
Methods: 62.5% ( 5 / 8 )
Lines: 81.63% ( 40 / 49 )
Branches: 44.44% ( 8 / 18 )

Copy link

Coverage Report (Frontend)

Totals Coverage
Statements: 50.6% ( 169 / 334 )
Methods: 50% ( 37 / 74 )
Lines: 55.67% ( 108 / 194 )
Branches: 36.36% ( 24 / 66 )

Signed-off-by: Jeremy Ho <jujaga@gmail.com>
@jujaga jujaga merged commit 688d510 into master Dec 22, 2023
19 checks passed
@jujaga jujaga deleted the ci/dockerfile branch December 22, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants