New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getGitRevision mishandling HEAD file read #6

Merged

TimCsaky merged 1 commit into master from bugfix/gitrev

Nov 3, 2023

Contributor

kyle1morel commented Nov 3, 2023

Description

Types of changes

Checklist

I have read the CONTRIBUTING doc
I have checked that unit tests pass locally with my changes
I have added tests that prove my fix is effective or that my feature works
I have added necessary documentation (if appropriate)

Further comments


          Fix getGitRevision mishandling HEAD file read

b9d3850

kyle1morel requested review from jujaga, norrisng-bc, TimCsaky, jatindersingh93 and wilwong89 as code owners

November 3, 2023 17:24

jujaga approved these changes

View reviewed changes

github-actions bot commented Nov 3, 2023

Coverage Report (Frontend)

Totals
Statements:	53.78% ( 192 / 357 )
Methods:	54.32% ( 44 / 81 )
Lines:	59.05% ( 124 / 210 )
Branches:	36.36% ( 24 / 66 )

github-actions bot commented Nov 3, 2023

Coverage Report (Application)

Totals
Statements:	70.67% ( 53 / 75 )
Methods:	62.5% ( 5 / 8 )
Lines:	81.63% ( 40 / 49 )
Branches:	44.44% ( 8 / 18 )

TimCsaky merged commit d5a22d1 into master

17 checks passed

jujaga deleted the bugfix/gitrev branch

November 3, 2023 17:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jujaga jujaga approved these changes

norrisng-bc Awaiting requested review from norrisng-bc norrisng-bc is a code owner

TimCsaky Awaiting requested review from TimCsaky TimCsaky is a code owner

jatindersingh93 Awaiting requested review from jatindersingh93 jatindersingh93 is a code owner

wilwong89 Awaiting requested review from wilwong89

Labels

None yet