make filter method private

bci-oss · Aug 21, 2023 · 6a56248 · 6a56248
1 parent ced9d25
commit 6a56248
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/...end/src/main/java/org/eclipse/tractusx/semantics/registry/service/ShellAccessHandler.java b/...end/src/main/java/org/eclipse/tractusx/semantics/registry/service/ShellAccessHandler.java
@@ -83,7 +83,7 @@ public Shell filterShellProperties( Shell shell, String externalSubjectId ) {
       return shell.withIdentifiers( filteredIdentifiers );
    }
 
-   public Set<ShellIdentifier> filterSpecificAssetIdsByTenantId( Set<ShellIdentifier> shellIdentifiers, String tenantId ) {
+   private Set<ShellIdentifier> filterSpecificAssetIdsByTenantId( Set<ShellIdentifier> shellIdentifiers, String tenantId ) {
       // the owning tenant should always see all identifiers
       if ( tenantId.equals( owningTenantId ) ) {
          return shellIdentifiers;

diff --git a/backend/src/main/java/org/eclipse/tractusx/semantics/registry/service/ShellService.java b/backend/src/main/java/org/eclipse/tractusx/semantics/registry/service/ShellService.java
@@ -241,8 +241,8 @@ public List<String> findExternalShellIdsByIdentifiersByAnyMatch(Set<ShellIdentif
     @Transactional(readOnly = true)
     public List<Shell> findShellsByExternalShellIds(Set<String> externalShellIds,String externalSubjectId) {
         return shellRepository.findShellsByIdExternalIsIn(externalShellIds).stream()
-                .map(shell ->  shell.withIdentifiers(shellAccessHandler.filterSpecificAssetIdsByTenantId(shell.getIdentifiers(), externalSubjectId)))
-                .collect(Collectors.toList());
+              .map(shell -> shellAccessHandler.filterShellProperties( shell, externalSubjectId ))
+              .collect(Collectors.toList());
     }
 
    @Transactional