Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: use Address for bulk tx and utxo reads #93

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

http: use Address for bulk tx and utxo reads #93

wants to merge 2 commits into from

Conversation

boymanjor
Copy link
Contributor

@boymanjor boymanjor commented Sep 22, 2018

The fixed endpoints are being considered for deprecation.
For now, this commit adds a warning message to the logs
and a TODO to deprecate once the necessary functionality
is added to the wallet API.

@codecov-io
Copy link

codecov-io commented Sep 22, 2018

Codecov Report

Merging #93 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #93      +/-   ##
=========================================
- Coverage   55.23%   55.2%   -0.03%     
=========================================
  Files         109     109              
  Lines       27039   27047       +8     
  Branches     4472    4472              
=========================================
- Hits        14934   14932       -2     
- Misses      12105   12115      +10
Impacted Files Coverage Δ
lib/node/http.js 38.36% <0%> (-0.78%) ⬇️
lib/coins/compress.js 55.06% <0%> (-1.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28cf1ef...7b6b203. Read the comment docs.

@braydonf
Copy link
Contributor

braydonf commented Sep 22, 2018

Ditto a comment at bcoin-org/bcoin#612 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants