Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: bslint test error in CI #1181

Closed
wants to merge 4 commits into from
Closed

test: bslint test error in CI #1181

wants to merge 4 commits into from

Conversation

MashyBasker
Copy link

Overview

This change fixes the CI lint error in the test bcoin/test/descriptor-test.js due to the usage of the hasOwnProperty call on a local object.

Reference/Stackoverflow

Signed-off-by: Maharshi Basu <basumaharshi10@gmail.com>
Signed-off-by: Maharshi Basu <basumaharshi10@gmail.com>
Signed-off-by: Maharshi Basu <basumaharshi10@gmail.com>
Signed-off-by: Maharshi Basu <basumaharshi10@gmail.com>
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0c18028) 70.41% compared to head (714e59f) 69.83%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1181      +/-   ##
==========================================
- Coverage   70.41%   69.83%   -0.59%     
==========================================
  Files         174      174              
  Lines       27515    27515              
==========================================
- Hits        19376    19215     -161     
- Misses       8139     8300     +161     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MashyBasker MashyBasker closed this by deleting the head repository May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant