Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: bslint test error in CI #1181

Closed
wants to merge 4 commits into from
Closed

test: bslint test error in CI #1181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f26b97c
chore: update to support bslint in eslint config
MashyBasker Feb 12, 2024
6a5573a
chore: match lint config file with bcrypto
MashyBasker Feb 12, 2024
6f39c70
test: fix error bslint error due to hasOwnProperty call
MashyBasker Feb 12, 2024
714e59f
fix: failing test due to change in hasOwnProperty call on validAddresses
MashyBasker Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,9 @@
{
"env": {
"es6": true,
"es2024": true,
"node": true
},
"extends": "eslint:recommended",
"globals": {
"Atomics": "readable",
"BigInt": "readable",
"BigInt64Array": "readable",
"BigUint64Array": "readable",
"queueMicrotask": "readable",
"SharedArrayBuffer": "readable",
"TextEncoder": "readable",
"TextDecoder": "readable"
},
"overrides": [
{
"files": ["*.mjs"],
Expand Down Expand Up @@ -43,9 +33,8 @@
}
}
],
"parser": "babel-eslint",
"parserOptions": {
"ecmaVersion": 10,
"ecmaVersion": "latest",
"ecmaFeatures": {
"globalReturn": true
},
Expand Down
4 changes: 2 additions & 2 deletions test/descriptor-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ function createDescriptorFromOptions(desc, type) {

describe('Descriptor', () => {
for (const type in parsable) {
if (parsable.hasOwnProperty(type)) {
if (Object.prototype.hasOwnProperty.call(type)) {
for (const data of parsable[type]) {
const {input, descriptor, checksum, isrange, issolvable, hasprivatekeys, requirechecksum, network} = data;

Expand Down Expand Up @@ -111,7 +111,7 @@ describe('Descriptor', () => {
}

for (const type in validAddresses) {
if (validAddresses.hasOwnProperty(type)) {
if (validAddresses.hasOwnProperty.call(type)) {
for (const data of validAddresses[type]) {
const {input, network, range, error} = data;

Expand Down
Loading