Multiple probes WIP [not for pull!] #243
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for support of multiple probes. Basically the idea is to have multiple probes in the 'probes' section. The probes combined just work like the old probe functionality.
The API of ISR's was changed to make future changes easier with timing / debouncing. The only ISR that is being used is the 'change' ISR, which now is the only ISR in the pin class. Other ISR's are just irrelevant. For probing this is especially important, because the exact moment of the ISR has to be captured (and not the time when the ISR was resolved into the precise pin - which is the case for f.ex. pin extenders and more advanced probes like BLTouch).
For now, only the SimpleProbe is implemented. Tool setter is a simple probe for now.
DONE:
TODO: