address comment

beam-cloud · Jan 2, 2025 · 7ecfa9d · 7ecfa9d
1 parent db32869
commit 7ecfa9d
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/pkg/abstractions/shell/http.go b/pkg/abstractions/shell/http.go
@@ -93,9 +93,8 @@ func (g *shellGroup) ShellConnect(ctx echo.Context) error {
 	// Wait for either connection to close
 	select {
 	case <-done:
-		clientCancel()
+		return nil
 	case <-clientCtx.Done():
+		return nil
 	}
-
-	return nil
 }