From 7ecfa9d2abaa139c8685ba98123e9d85479d4b25 Mon Sep 17 00:00:00 2001
From: luke-lombardi <33990301+luke-lombardi@users.noreply.github.com>
Date: Thu, 2 Jan 2025 15:23:26 -0500
Subject: [PATCH] address comment

---
 pkg/abstractions/shell/http.go | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/pkg/abstractions/shell/http.go b/pkg/abstractions/shell/http.go
index 1b7edbe50..4388a26e6 100644
--- a/pkg/abstractions/shell/http.go
+++ b/pkg/abstractions/shell/http.go
@@ -93,9 +93,8 @@ func (g *shellGroup) ShellConnect(ctx echo.Context) error {
 	// Wait for either connection to close
 	select {
 	case <-done:
-		clientCancel()
+		return nil
 	case <-clientCtx.Done():
+		return nil
 	}
-
-	return nil
 }