From 7fae1dd880833e8fbb484db75e67e02841858b13 Mon Sep 17 00:00:00 2001 From: Daniel Levi-Minzi <51272568+dleviminzi@users.noreply.github.com> Date: Thu, 19 Dec 2024 21:01:47 -0500 Subject: [PATCH] Fix: Remove instance spec from exec env (#802) For some reason this was causing our base requirement installation to fail. I suspect it might have been duplicating some of the env vars from the base spec, which might have been causing issues. We should investigate adding the vars not already included and see if that still causes issues. For now, this seems to fix the problem. --- pkg/worker/runc_server.go | 1 - 1 file changed, 1 deletion(-) diff --git a/pkg/worker/runc_server.go b/pkg/worker/runc_server.go index 24a77548e..6796555b0 100644 --- a/pkg/worker/runc_server.go +++ b/pkg/worker/runc_server.go @@ -111,7 +111,6 @@ func (s *RunCServer) RunCExec(ctx context.Context, in *pb.RunCExecRequest) (*pb. if !exists { return &pb.RunCExecResponse{Ok: false}, nil } - process.Env = append(process.Env, instance.Spec.Process.Env...) if instance.Request.IsBuildRequest() { process.Env = append(process.Env, instance.Request.BuildOptions.BuildSecrets...) }