Feat: Add warm up endpoint to both endpoints and taskqueues #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-lombardi
requested changes
Dec 26, 2024
| @@ -434,6 +434,9 @@ func (rb *RequestBuffer) handleHttpRequest(req *request, c container) { | |||
| } | |||
|
|
|||
| containerUrl := fmt.Sprintf("http://%s/%s", c.address, req.ctx.Param("subPath")) | |||
| if req.task.msg.NoOp { | |||
There was a problem hiding this comment.
Feels like there a simpler way to do this that doesn't "trick" the system into warming up the task queue. Why not just have the warm up endpoint launch a container and set a keep warm on it so the autoscaler can't shut it down?
jsun-m
deleted the
john/be-2165-spike-start-up-endpoint-for-deployments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new variable
NoOpto theTaskMessagedata model which only exists in Redis. If this variable is detected to be true in a task, the idea is that the task handler will detect it and run it as a fake task just so it can complete and start up the timer for the keep warm.