Fix: Add a TTL on build containers for cleanup #819
+104
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsun-m
changed the title
luke-lombardi
requested changes
Jan 5, 2025
| case <-done: | ||
| return | ||
| case <-ticker.C: | ||
| b.rdb.Set(ctx, Keys.imageContainerTTL(containerId), "1", time.Duration(imageContainerTtlS)*time.Second).Err() |
There was a problem hiding this comment.
Should this be called imageBuildContainerTTL? I know it's technically the "image" service, but the prefix on containers is build-
| @@ -194,3 +245,15 @@ func convertBuildSteps(buildSteps []*pb.BuildStep) []BuildStep { | |||
| } | |||
| return steps | |||
| } | |||
|
|
|||
| var ( | |||
| imageContainerTTL string = "image:container_ttl:%s" | |||
There was a problem hiding this comment.
maybe call this image:build_container_ttl and var imageBuildContainerTTL
| } | ||
|
|
||
| const containerKeepAliveIntervalS int = 30 |
There was a problem hiding this comment.
Var names could be improved here. Maybe buildContainerKeepAliveIntervalS
and imageBuildContainerTtlS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a key event manager to image service with a imageContainerTTL key to identified expired build containers