[WIP] Big breaking change...and replication logic #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Stagging branch
- Cleaned up README to give users a better heads up of the changes coming
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
=======================================
Coverage 87.67% 87.67%
=======================================
Files 3 3
Lines 73 73
=======================================
Hits 64 64
Misses 9 9Continue to review full report at Codecov.
|
- hopefully the last readme cleanup
- standardizing verbaige accross library - added docs for 2 new `Mnesiac.Store` optional callbacks
[skip travis] - THIS IS GOING TO BREAK THE BRANCH - more documentation updates around breaking changes in library to come.
beardedeagle
changed the title
[skip travis] - STILL BROKEN - Solidified api for migrations
[skip travis] - STILL BROKEN - README correction about migration config api
[skip travis]
- STILL BROKEN
- mentioing another change. basically making it possible for library users to define their own config structure. Users can now pass in a fun that will convert the custom config to their own struct and pass it to `Mnesiac.Store` for user. This means they would also need to ensure they overide the store macros or at least provide the doc'd struct fields for `%Mnesiac.Store{}`.
[skip travis] - STILL VERY VERY BROKEN. DO NOT USE - dep updates - minor type fix in changelog - committing supervisor code
[skip travis] - STILL VERY VERY BROKEN. DO NOT USE - more doc cleanup - more verbaige standardization
[skip travis] - STILL VERY VERY BROKEN. DO NOT USE - added typespecs to define expected config structure for default library usage - removed config from formatter
[skip travis] - STILL VERY VERY BROKEN. DO NOT USE - Added `refresh_cluster/1` callback - Added `backup/1` callback - small fixes
[skip travis] - STILL VERY VERY BROKEN. DO NOT USE - committing cursory mnesiac module changes - fixing type in `Mnesiac.Supervisor` - making readme example legal sytax
[skip travis] - STILL VERY VERY BROKEN. DO NOT USE - Moving `build_struct/2` down in logic for proper flow
[skip travis] - STILL VERY VERY BROKEN. DO NOT USE - Fixing override type to include the proper returns expected - updated `built_struct/2` to capture and pass on error tuples for overrides
[skip travis] - STILL VERY VERY BROKEN. DO NOT USE - Adding `Mnesiac.validate_config/2`
[skip travis] - STILL VERY VERY BROKEN. DO NOT USE - calling `init_schema/1` now - general cleanup
[skip travis] - STILL VERY VERY BROKEN. DO NOT USE - moving types out of supervisor module and into correct modules. will leave an explicit doc callout in supervisor for what is explicitly expected to be passed. - committing store macro with 0.3.3 functionaltiy in tact, but with all added overridables for sanity.
[skip travis] - STILL VERY VERY BROKEN. DO NOT USE - Updated deps - Updated Supervisor docs - Updated credo config - Updated OTP version in project
[skip travis] - STILL VERY VERY BROKEN. DO NOT USE - Elixir dep updates - OTP update
|
Closing in favor of more cleaned up pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/Addresses
#9 - Replication logic...with a lot more tacked on.
Change proposed in this pull request
Staging this pr. Work in progress. Whole lot of scope creep going on in here. The reason being is that this change would introduce breaking changes anyway. Might as well try to roll as many breaking changes into one well tested, and documented, change.
init_migration/1androllback_migration/1toMnesiac.Storeto allow users to implement custom migration logic.refresh_cluster/1for custom logic pertaining to refreshing Mnesia Cluster.backup/1for custom logic pertaining to backing up Mnesia stores.Mnesiac.Storeinstead of the default library implementation.Mnesiac.validate_config/2, which can also be used to look at output from override fun for validation.resolve_conflict/1toresolve_conflict/2, now accepts configuration.Mnesiac.StoreManagermodule.Mnesiac. Expect a smaller public facing api.Branch is currently broken as I shuffle things around.
Check list
Additional info
Cleaned up the GitHub templates. Made them less "fire and brimstoney"