Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop php-cs-fixer and setup phpcs #423

Merged
merged 43 commits into from
Feb 5, 2024
Merged

Drop php-cs-fixer and setup phpcs #423

merged 43 commits into from
Feb 5, 2024

Commits on Jan 27, 2024

  1. Remove php cs fixer

    @connorhu
    connorhu committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    cf6f348 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2024

  1. Add php_codesniffer, doctrine/coding-standard

    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    157e4b4 View commit details
    Browse the repository at this point in the history

  2. Code Sniffer: apply rule SlevomatCodingStandard.TypeHints.DeclareStri… 

    …ctTypes.DeclareStrictTypesMissing
    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    04ef469 View commit details
    Browse the repository at this point in the history

  3. Code Sniffer: apply rule SlevomatCodingStandard.Namespaces.ReferenceU… 

    …sedNamesOnly.ReferenceViaFullyQualifiedName
    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    4534bc9 View commit details
    Browse the repository at this point in the history

  4. Code Sniffer: apply rule SlevomatCodingStandard.Commenting.ForbiddenA… 

    …nnotations.AnnotationForbidden
    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    a457b63 View commit details
    Browse the repository at this point in the history

  5. Code Sniffer: apply rule SlevomatCodingStandard.Namespaces.ReferenceU… 

    …sedNamesOnly.ReferenceViaFallbackGlobalName
    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    4a320b7 View commit details
    Browse the repository at this point in the history

  6. Code Sniffer: apply rule SlevomatCodingStandard.ControlStructures.Dis… 

    …allowYodaComparison.DisallowedYodaComparison
    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    d53710e View commit details
    Browse the repository at this point in the history

  7. Code Sniffer: apply rule PSR12.Operators.OperatorSpacing.*

    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    4c1a7a7 View commit details
    Browse the repository at this point in the history

  8. Code Sniffer: apply rule SlevomatCodingStandard.Commenting.RequireOne… 

    …LineDocComment.MultiLineDocComment
    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    eaa93b5 View commit details
    Browse the repository at this point in the history

  9. Code Sniffer: apply rule SlevomatCodingStandard.TypeHints.ReturnTypeH… 

    …int.UselessAnnotation
    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    7dd4ca3 View commit details
    Browse the repository at this point in the history

  10. Code Sniffer: apply rule SlevomatCodingStandard.Operators.DisallowEqu… 

    …alOperators.*
    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    1519b51 View commit details
    Browse the repository at this point in the history

  11. Code Sniffer: apply rule PSR2.ControlStructures.SwitchDeclaration.Bre… 

    …akIndent
    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    3294d9f View commit details
    Browse the repository at this point in the history

  12. Code Sniffer: apply rule Generic.Formatting.SpaceAfterNot.Incorrect

    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    9e8c0c3 View commit details
    Browse the repository at this point in the history

  13. Code Sniffer: apply rule SlevomatCodingStandard.ControlStructures.Blo… 

    …ckControlStructureSpacing.IncorrectLinesCountAfterControlStructure
    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    16a2f7e View commit details
    Browse the repository at this point in the history

  14. Code Sniffer: apply rule PSR12.ControlStructures.ControlStructureSpac… 

    …ing.FirstExpressionLine & CloseParenthesisLine
    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    a5c044b View commit details
    Browse the repository at this point in the history

  15. Code Sniffer: apply rule Generic.Formatting.MultipleStatementAlignmen… 

    …t.NotSame
    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    d77b123 View commit details
    Browse the repository at this point in the history

  16. Code Sniffer: apply rule SlevomatCodingStandard.Classes.DisallowLateS… 

    …taticBindingForConstants.DisallowedLateStaticBindingForConstant
    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    f29d220 View commit details
    Browse the repository at this point in the history

  17. Code Sniffer: apply rule SlevomatCodingStandard.Commenting.DocComment… 

    …Spacing.IncorrectOrderOfAnnotationsGroup
    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    949ead1 View commit details
    Browse the repository at this point in the history

  18. Code Sniffer: apply rule SlevomatCodingStandard.PHP.UselessParenthese… 

    …s.UselessParentheses
    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    4814ea2 View commit details
    Browse the repository at this point in the history

  19. Code Sniffer: apply rule SlevomatCodingStandard.TypeHints.ReturnTypeH… 

    …int.MissingNativeTypeHint
    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    42c9f39 View commit details
    Browse the repository at this point in the history

  20. Code Sniffer: manual fix rule Squiz.NamingConventions.ValidVariableNa… 

    …me.NotCamelCaps
    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    0466a63 View commit details
    Browse the repository at this point in the history

  21. Code Sniffer: manual fix rule Squiz.Strings.DoubleQuoteUsage.ContainsVar

    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    1bc0c03 View commit details
    Browse the repository at this point in the history

  22. Code Sniffer: manual fix rule Squiz.Commenting.FunctionComment.Missin… 

    …gParamName
    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    12914a2 View commit details
    Browse the repository at this point in the history

  23. Code Sniffer: manual fix rule SlevomatCodingStandard.TypeHints.Return… 

    …TypeHint.*
    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    a85ac5e View commit details
    Browse the repository at this point in the history

  24. Code Sniffer: apply rule Squiz.Strings.DoubleQuoteUsage.NotRequired

    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    06e39a6 View commit details
    Browse the repository at this point in the history

  25. Code Sniffer: manual fix visibility missing

    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    ac2fad9 View commit details
    Browse the repository at this point in the history

  26. Code Sniffer: manual fix "Each index in a multi-line array must be on… 

    … a new line"
    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    2145ae2 View commit details
    Browse the repository at this point in the history

  27. Code Sniffer: manual fix "Space found before/after square bracket"

    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    0630ea2 View commit details
    Browse the repository at this point in the history

  28. Code Sniffer: manual fix Squiz.Strings.DoubleQuoteUsage.ContainsVar

    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    db1f5a0 View commit details
    Browse the repository at this point in the history

  29. Code Sniffer: manual fix PSR2.Methods.MethodDeclaration.Underscore

    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    5371b08 View commit details
    Browse the repository at this point in the history

  30. Code Sniffer: manual fix SlevomatCodingStandard.TypeHints.ReturnTypeH… 

    …int.MissingAnyTypeHint
    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    c0ff1c1 View commit details
    Browse the repository at this point in the history

  31. Code Sniffer: manual fix Squiz.Strings.DoubleQuoteUsage.ContainsVar

    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    4aa592b View commit details
    Browse the repository at this point in the history

  32. Code Sniffer: apply rule Generic.Formatting.MultipleStatementAlignmen… 

    …t.NotSame
    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    2ff2d11 View commit details
    Browse the repository at this point in the history

  33. Code Sniffer: manual fix Squiz.Strings.DoubleQuoteUsage.ContainsVar

    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    6b4fd1e View commit details
    Browse the repository at this point in the history

  34. Code Sniffer: manual fix SlevomatCodingStandard.TypeHints.ReturnTypeH… 

    …int.MissingTraversableTypeHintSpecification
    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    9116b6b View commit details
    Browse the repository at this point in the history

  35. Code Sniffer: apply rule 'Expected 1 line after "parent", found 0.'

    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    87a013d View commit details
    Browse the repository at this point in the history

  36. Code Sniffer: misc fixes

    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    57b9c47 View commit details
    Browse the repository at this point in the history

  37. Code Sniffer: fix "Found multi-line doc comment with single line cont… 

    …ent"
    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    cc9cdaf View commit details
    Browse the repository at this point in the history

  38. Code Sniffer: fix "Member variable ... is not in valid camel caps for… 

    …mat"
    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    bdebe1c View commit details
    Browse the repository at this point in the history

  39. Revert "Code Sniffer: apply rule SlevomatCodingStandard.TypeHints.Dec… 

    …lareStrictTypes.DeclareStrictTypesMissing"

This reverts commit 0308030.
    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    cb46fd7 View commit details
    Browse the repository at this point in the history

  40. Revert "Code Sniffer: apply rule SlevomatCodingStandard.Commenting.Fo… 

    …rbiddenAnnotations.AnnotationForbidden"
    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    d073e31 View commit details
    Browse the repository at this point in the history

  41. add two exluded rules: forbidden annotation and strict types

    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    ea294bf View commit details
    Browse the repository at this point in the history

  42. convert phpdoc to one-liner

    @connorhu
    connorhu committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    8cb11a5 View commit details
    Browse the repository at this point in the history