Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with https://fhirpath-lab.com/FhirPath #30

Open
ir4y opened this issue Nov 9, 2023 · 2 comments
Open

Integrate with https://fhirpath-lab.com/FhirPath #30

ir4y opened this issue Nov 9, 2023 · 2 comments
Assignees

Comments

@ir4y
Copy link
Member

ir4y commented Nov 9, 2023

https://github.com/brianpos/fhirpath-lab/blob/develop/server-api.md

@ir4y
Copy link
Member Author

ir4y commented Nov 9, 2023

Some comments from Brian Postlethwaite

These are the logical models for what data is in/out of the custom operation
Simplified logical models for what data in the request/response.

image(1) image(2)

But represented using fhir parameters resources.
I'm trying to get real profiles for these to go with things too.
The Abstract Syntax tree format isn't documented anywhere. I built it from the Firely engine, and mapped the fhirpath.js to that. In progress mapping the HAPI engine to it too.
The tricky part is making it work with the "invert tree" format to make it more readable.

@ir4y
Copy link
Member Author

ir4y commented May 13, 2024

From https://github.com/brianpos/

Hey Ilya, I tried out the branch with the python engine in it and looks like it works reasonable well.
I did note that your results are coming out as a single result.
If a context expression comes through, it should return multiple results, one for each result from the context expression.
Also, you might like to append the version number of your engine in the string that you return for the evaluator (if you have one)
e.g. "valueString": "fhirpath-py" => "valueString": "fhirpath-py (x.y.z)"
This is from the HAPI engine
image.png
This is from yours
image.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants