Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[common]: Changed pullSecret from string to bool #110

Merged
merged 3 commits into from
Aug 17, 2023

Conversation

TobyTheHutt
Copy link
Contributor

@TobyTheHutt TobyTheHutt commented Aug 7, 2023

What this PR does:
The PR changes the data type of the pullSecret from string to bool.
This removes some confusion for the key, since the provided value will in no scenario influence the name of the secret.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):
fixes #109

Notes for Reviewer:
This PR is a quick solution which does not change the behaviour of the chart itself. It is only to help prevent confusion when trying to use that value.

If desired, I will also commit an additional optional Values.secrets.data.registry.pullSecret.name value which will then generate the pullSecret with the pattern {{ template "library.name" $root }}-{{ $name }}.

Checklist:

  • Pull Request title in format [chart]: Changed Something
  • Updated documentation in the README.md.gotmpl file and executed helm-docs
  • Chart Version bumped
  • All commits are signed-off

Signed-off-by: Tobias Harnickell <tobias.harnickell@bedag.ch>
Signed-off-by: Tobias Harnickell <tobias.harnickell@bedag.ch>
@TobyTheHutt TobyTheHutt requested a review from a team as a code owner August 7, 2023 16:28
@TobyTheHutt TobyTheHutt self-assigned this Aug 7, 2023
@TobyTheHutt TobyTheHutt linked an issue Aug 7, 2023 that may be closed by this pull request
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 7, 2023
Signed-off-by: Tobias Harnickell <tobias.harnickell@bedag.ch>
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 7, 2023
@TobyTheHutt TobyTheHutt removed their assignment Aug 8, 2023
@TobyTheHutt TobyTheHutt merged commit c0cdb7a into master Aug 17, 2023
6 checks passed
@TobyTheHutt TobyTheHutt deleted the feat/pullsecret_handling branch August 17, 2023 15:53
@TobyTheHutt TobyTheHutt self-assigned this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[common] pullSecret Name cannot be supplied
2 participants