[common]: Changed pullSecret
from string
to bool
#110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
The PR changes the data type of the
pullSecret
fromstring
tobool
.This removes some confusion for the key, since the provided value will in no scenario influence the name of the
secret
.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged):fixes #109
Notes for Reviewer:
This PR is a quick solution which does not change the behaviour of the chart itself. It is only to help prevent confusion when trying to use that value.
If desired, I will also commit an additional optional
Values.secrets.data.registry.pullSecret.name
value which will then generate thepullSecret
with the pattern{{ template "library.name" $root }}-{{ $name }}
.Checklist:
[chart]: Changed Something
README.md.gotmpl
file and executedhelm-docs