Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[common]: Fix ability to set configMaps & secret for every container i… #114

Merged
merged 1 commit into from
Sep 1, 2023
Merged

[common]: Fix ability to set configMaps & secret for every container i… #114

merged 1 commit into from
Sep 1, 2023

Conversation

adberger
Copy link
Contributor

@adberger adberger commented Sep 1, 2023 •
edited
Loading

…n pod

What this PR does:

Fixes a bug introduced in #112

Checklist:

  • Pull Request title in format [chart]: Changed Something
  • Updated documentation in the README.md.gotmpl file and executed helm-docs
  • Chart Version bumped
  • All commits are signed-off

@adberger adberger requested a review from a team as a code owner September 1, 2023 10:50
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 1, 2023
@adberger
[common]: Fix ability to set configMaps & secret for every container …
ba9028a 
…in pod

Signed-off-by: Adrian Berger <adrian.berger@bedag.ch>
@adberger adberger changed the title [common] Fix ability to set configMaps & secret for every container i… [common]: Fix ability to set configMaps & secret for every container i… Sep 1, 2023
brjos
brjos approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@brjos brjos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adberger adberger merged commit 2ddda80 into bedag:master Sep 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brjos brjos brjos approved these changes

@oliverbaehler oliverbaehler Awaiting requested review from oliverbaehler oliverbaehler is a code owner automatically assigned from bedag/sre

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adberger @brjos