Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[common]: add volume type csi #121

Merged
merged 2 commits into from
Oct 31, 2023
Merged

[common]: add volume type csi #121

merged 2 commits into from
Oct 31, 2023

Conversation

janlauber
Copy link
Contributor

What this PR does: It adds the volume type "csi" to the pod template.

Checklist:

  • Pull Request title in format [chart]: Changed Something
  • Updated documentation in the README.md.gotmpl file and executed helm-docs
  • Chart Version bumped
  • All commits are signed-off

@janlauber
feat(common): add volume type csi
6fb2621 
Signed-off-by: Jan Lauber <jan.lauber@protonmail.ch>
@janlauber janlauber requested a review from a team as a code owner October 30, 2023 20:37
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 30, 2023
@janlauber
fix(common): _pod.yaml
dadd6af 
Signed-off-by: Jan Lauber <jan.lauber@protonmail.ch>
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 30, 2023
adberger
adberger approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@adberger adberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for your contribution @janlauber :)

@adberger adberger merged commit 532ed46 into bedag:master Oct 31, 2023
4 checks passed
@janlauber janlauber deleted the add-csi-volumes branch October 31, 2023 07:02
@janlauber janlauber mentioned this pull request Oct 31, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adberger adberger adberger approved these changes

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janlauber @adberger