Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcluster]: fix some etcd backup job values werde not intended correctly #127

Merged
merged 1 commit into from
Jan 4, 2024
Merged

[vcluster]: fix some etcd backup job values werde not intended correctly #127

merged 1 commit into from
Jan 4, 2024

Conversation

adberger
Copy link
Contributor

@adberger adberger commented Jan 4, 2024

What this PR does:

The indentation for some values is wrong for the etcd backup job.
This PR fixes these

Checklist:

  • Pull Request title in format [chart]: Changed Something
  • Updated documentation in the README.md.gotmpl file and executed helm-docs
  • Chart Version bumped
  • All commits are signed-off

@adberger
fix: some etcd backup job values werde not intended correctly
8c5281d 
Signed-off-by: Adrian Berger <adrian.berger@bedag.ch>
@adberger adberger requested a review from a team as a code owner January 4, 2024 09:26
@adberger adberger requested a review from brjos January 4, 2024 09:26
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 4, 2024
lucakuendig
lucakuendig approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@lucakuendig lucakuendig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok so

@adberger adberger merged commit 61cb0d4 into bedag:master Jan 4, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucakuendig lucakuendig lucakuendig approved these changes

@brjos brjos Awaiting requested review from brjos brjos is a code owner automatically assigned from bedag/sre

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adberger @lucakuendig