Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcluster]: delete uds file if it already exists when starting kon… #128

Merged
merged 1 commit into from
Feb 26, 2024
Merged

[vcluster]: delete uds file if it already exists when starting kon… #128

merged 1 commit into from
Feb 26, 2024

Conversation

adberger
Copy link
Contributor

What this PR does:

The defined version (v0.0.37) of apiserver-network-proxy doesn't delete the uds file prior to starting the konnectivity-server by default.
Newer versions have this flag enabled by default.

For now, we manually enable this flag.

ref: kubernetes-sigs/apiserver-network-proxy#476

Checklist:

  • Pull Request title in format [chart]: Changed Something
  • Updated documentation in the README.md.gotmpl file and executed helm-docs
  • Chart Version bumped
  • All commits are signed-off

…nectivity-server

Signed-off-by: Adrian Berger <adria.berger94@gmail.com>
@adberger adberger requested a review from a team as a code owner February 26, 2024 11:33
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 26, 2024
larsgerber
larsgerber previously approved these changes Feb 26, 2024
@larsgerber larsgerber dismissed their stale review February 26, 2024 11:38

Unnecessary approval

@adberger adberger merged commit 2e3776f into bedag:master Feb 26, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants