[common]: make clusterIP independent of LoadBalancer #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows headless services (i.e.: setting ClusterIP: None for non-LoadBalancer types)
github-actions
bot
added
the
size/XS
|
Thank you @HonoluluHenk for your contribution. Please refer to the checklist in the PR description (version bump) and fulfill the checks in the separate tab. There are detailed instructions for fulfilling the DCO check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This allows headless services (i.e.: setting ClusterIP: None for non-LoadBalancer types)
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Notes for Reviewer:
Test compatibility with existing charts
Checklist:
[chart]: Changed SomethingREADME.md.gotmplfile and executedhelm-docs