Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[common]: support for defining multiple hosts for an Ingress #138

Merged
merged 7 commits into from
Nov 15, 2024
Merged

[common]: support for defining multiple hosts for an Ingress #138

merged 7 commits into from
Nov 15, 2024

Conversation

wthhub
Copy link
Contributor

@wthhub wthhub commented Oct 30, 2024 •
edited
Loading

What this PR does: This PR enhances the common chart with the ability to define multiple hosts (with and without existing secrets) for one single ingress.

Notes for Reviewer:

Checklist:

  • Pull Request title in format [chart]: Changed Something
  • Updated documentation in the README.md.gotmpl file and executed helm-docs
  • Chart Version bumped
  • All commits are signed-off

@wthhub wthhub requested a review from a team as a code owner October 30, 2024 14:05
@wthhub wthhub requested a review from brjos October 30, 2024 14:05
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 30, 2024
@wthhub wthhub force-pushed the feat/add-multiple-hosts-for-ingress branch from c060db7 to 8a22314 Compare October 30, 2024 14:08
@wthhub wthhub removed the request for review from brjos October 30, 2024 14:10
@wthhub
feat(common): add pr number
2eee6fc 
Signed-off-by: Thomas Wessner <thomas.wessner@bedag.ch>
@wthhub wthhub force-pushed the feat/add-multiple-hosts-for-ingress branch from 8a22314 to 2eee6fc Compare October 30, 2024 14:20
@wthhub
feat(common): add pr number
3d1ceff 
Signed-off-by: Thomas Wessner <thomas.wessner@bedag.ch>
@wthhub wthhub requested a review from fanks4 October 31, 2024 09:11
fanks4
fanks4 reviewed Nov 14, 2024
View reviewed changes
Copy link

@fanks4 fanks4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request @wthhub. It looks good to me. I added a comment because I had a question to a comment.

charts/common/values.yaml Outdated Show resolved Hide resolved
@wthhub wthhub force-pushed the feat/add-multiple-hosts-for-ingress branch from fc2d8ef to 25cc997 Compare November 15, 2024 14:31
fanks4
fanks4 approved these changes Nov 15, 2024
View reviewed changes
Copy link

@fanks4 fanks4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the improvements @wthhub. Now it's clear to me which key and path to use.

@wthhub wthhub merged commit 3fab132 into master Nov 15, 2024
4 checks passed
@wthhub wthhub deleted the feat/add-multiple-hosts-for-ingress branch November 15, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanks4 fanks4 fanks4 approved these changes

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wthhub @fanks4