Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error causes config parser to go into infinite loop #3

Open
jabl opened this issue Feb 26, 2016 · 1 comment
Open

Syntax error causes config parser to go into infinite loop #3

jabl opened this issue Feb 26, 2016 · 1 comment
Labels

Comments

@jabl
Copy link

jabl commented Feb 26, 2016

I noticed when I had a config file with
[[ Repo ]]
instead of
[[Repo]]
git-mirror just hung and consumed 100% cpu when starting with no message printed to stderr/out. A bit of debugging turned out that the culprit was the toml parser which went into an infinite loop.

Perhaps switch to another toml parser, https://github.com/toml-lang/toml lists several ones for golang.

@beefsack
Copy link
Owner

Hi @jabl, thanks for the report, I'll confirm it's coming from the TOML parser and see if we can fix it upstream or look at changing libraries.

@beefsack beefsack added the bug label Mar 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants