-
-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: file-file md yang belum sesuai standar linter #203
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM untuk markdown
nya @sensasi-delight , mergify mungkin issue di konfigurasinya, bisa sekalian juga diganti konfigurasi dari mergify.yml
pada line 58
yang sebelumnya
- name: review docs team untuk file markdown
conditions:
- label=markdown files
actions:
request_reviews:
users:
- ikr4mm
- azqilana
menjadi
- name: review docs team untuk file markdown
conditions:
- label=markdown files
actions:
request_reviews:
teams:
- "@bellshade/php-team"
kemungkinan ketika sudah di change, akan dilakukan squash secara manual tanpa menggunakan mergify
@slowy07 hanya |
iyaa bener tinggal ganti ke user review ke |
@slowy07 konfigurasi bernama |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯 , tested mergify work on #207
Reviewed slowy07@googlebot.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge sorry for the late update. LGTM 🌟🚀. on behalf of docs & php team
hmm docs team udah ngga ada lagi, any idea biar pass checknya sens @slowy07 ? |
sementara dinonaktifkan dengan penjelasan seperti berikut:
penonaktifan akan efektif setelah PR ini di-merge. atau bisa juga dibentuk segera |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, waiting for merge
Closes
Deskripsi (Description)
Contributor Requirements (Syarat Kontributor)
README.md
tentang materi yang saya buatEnvironment
saya menggunakan (I am using):
os
=Windows 10
Testing
phpcs
phpcbf
Maintainer