-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LN key-up sound #9
Comments
One thing worth discussing: What should the expected behaviour be when a note with Should it be ignored (play as BGM), or should it be played as a regular note? |
Because For relief implementation, playing as a regular note (ignoring |
zardoru, wosderge, flicknote, suitougreentea, exclusion and I discussed the addition of this in a DM conversation on Twitter.
The idea is simple: The ending point of a LN plays a sound when the player releases the key.
This lets us emulate back-spin scratch from IIDX where a new sound is played at the note release, and it also offers more variety and interesting possibilities for chart creation.
Pictured above:
note1 with
l: 240
is a regular long note.note2 with
up: true
overlaps note1Due to
up: true
, the player will know that note2 is a key-up sound and not a regular note.note2 may also be in a different sound channel than note1. Like so:
Some key points from the discussion:
note1.y + note1.l == note2.y
as an overlap. We should make it explicitly clear that there is an overlap to ensure that all implementations are similar.The text was updated successfully, but these errors were encountered: