fix: Fix incorrect gobal export alias in buildFlatBarrel #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where an invalid export alias was generated when filenames
had segments that started with a number preceded by a dash or ".".
Examples using dashes and dots:
```typescript
export { default as testFile-1 } from "./directory1/test-file-1";
```
and
```typescript
export { default as testFile.1 } from "./directory1/test.file.1";
```
While underscores are allowed in aliases, dashes and dots is not.
Fix is to extend the regex to also include numbers.
|
Not sure if the way i mocked the file tree for this particular test case is kosher, but I would otherwise have to go through 17 failing tests and ensure they were fixed correctly which seemed more risky. But maybe I am being overly pragmatic :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where an invalid export alias was generated when filenames had segments that started with a number preceded by a dash or ".".
Examples using dashes and dots:
and
While underscores are allowed in aliases, dashes and dots are not.
Fix is to extend the regex to also include numbers.