You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In theory that should pass findReadme(undefined) then attempt to open https://npmjs.org/package/undefined (I guess) but instead opens https://npmjs.org/package/ which npm interprets as the package package.
A related issue is the key binding should only be triggered when "editorLangId == 'javascript' || ...".
The text was updated successfully, but these errors were encountered:
Hi @texastoland thanks for flagging this one - I haven't updated this plugin in a while, but will take a look at including fixes for these things in any upcoming release. In the meantime, feel free to PR any changes, would be happy to review those.
The following line doesn't account for cancellation:
vscode-node-readme/src/commands/showReadme.ts
Line 21 in 89b2d6f
In theory that should pass
findReadme(undefined)
then attempt to openhttps://npmjs.org/package/undefined
(I guess) but instead openshttps://npmjs.org/package/
which npm interprets as thepackage
package.A related issue is the key binding should only be triggered when
"editorLangId == 'javascript' || ..."
.The text was updated successfully, but these errors were encountered: