Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package package opened when input box canceled #41

Open
texastoland opened this issue Sep 26, 2021 · 2 comments
Open

package package opened when input box canceled #41

texastoland opened this issue Sep 26, 2021 · 2 comments

Comments

@texastoland
Copy link

texastoland commented Sep 26, 2021

The following line doesn't account for cancellation:

In theory that should pass findReadme(undefined) then attempt to open https://npmjs.org/package/undefined (I guess) but instead opens https://npmjs.org/package/ which npm interprets as the package package.

A related issue is the key binding should only be triggered when "editorLangId == 'javascript' || ...".

@bengreenier
Copy link
Owner

Hi @texastoland thanks for flagging this one - I haven't updated this plugin in a while, but will take a look at including fixes for these things in any upcoming release. In the meantime, feel free to PR any changes, would be happy to review those.

@texastoland
Copy link
Author

I'll give it a shot 🔜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants