Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests work on Windows and typos #257

Closed
wants to merge 2 commits into from

Conversation

seanyoung
Copy link
Contributor

No description provided.

@seanyoung seanyoung force-pushed the windows branch 4 times, most recently from a09fd9c to 28b5a08 Compare April 18, 2024 13:13
@bengtmartensson
Copy link
Owner

Hi Sean. Many thanks for your efforts. Comments:

  1. I would like to have the spelling fixes and the test fixes in separate commits. Is that OK?
  2. There is a problem with your fixes. The current program Runs/compiles on the age-old Java 8, which does not contain String.lines(), see https://docs.oracle.com/javase/8/docs/api/java/lang/String.html. There will come a day, and a reason, when I give up Java 8, but I do not consider your issue to be that reason. I ask you for a Java 8 version.

Signed-off-by: Sean Young <sean@mess.org>
@seanyoung
Copy link
Contributor Author

seanyoung commented Apr 18, 2024

  1. I would like to have the spelling fixes and the test fixes in separate commits. Is that OK?

Makes sense. I've made it into a separate commit.

  1. There is a problem with your fixes. The current program Runs/compiles on the age-old Java 8, which does not contain String.lines(), see https://docs.oracle.com/javase/8/docs/api/java/lang/String.html. There will come a day, and a reason, when I give up Java 8, but I do not consider your issue to be that reason. I ask you for a Java 8 version.

I've reimplemented without .lines(), I think it should work in Java 8.

Thanks!

@bengtmartensson
Copy link
Owner

Hi Sean,
I "deep dived" yesterday and found out interesting: The basic idea is that a multi-platform Java program should generate output in the native format for the platform it currently runs on. The tests are written in that vein. The failed tests are not "false positives", they really detect a problem. The culprit is JCommander, which generates help/usage texts using "\n" for all platforms. Bugreport. For this reason, I will not use your PR (the spell-fix commit "cherry-picked" though), but will implement another, more transparent solution.

Thank you very much for your efforts. Sorry for asking you for a Java-8 version that was not used anyhow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants