Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set sideEffects: false from @wry/caches #576

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Conversation

phryneas
Copy link
Collaborator

I just noticed that not all bundlers seem to split the .cjs output, even though both exports are independent from each other, so this should hopefully help.

Copy link
Owner

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @phryneas!

@benjamn benjamn merged commit 9e46e40 into main Nov 21, 2023
5 checks passed
@benjamn
Copy link
Owner

benjamn commented Nov 28, 2023

This change has been published in @wry/caches@1.0.1: https://npmdiff.dev/%40wry%2Fcaches/1.0.0/1.0.1/

@benjamn benjamn deleted the pr/caches-sideEffects branch November 28, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants