Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove SIX #255

Closed
wants to merge 1 commit into from
Closed

remove SIX #255

wants to merge 1 commit into from

Conversation

a-detiste
Copy link

@a-detiste a-detiste mentioned this pull request Nov 7, 2023
@bennylope
Copy link
Owner

This would be great! Getting rid of six is arguably one of the biggest chores in this project right now.

Unfortunately simply removing it like in ace42a1 isn't enough 😞, there's also some work required to update the "metaclass orchestration" https://github.com/bennylope/django-organizations/actions/runs/6787974831/job/18501285489?pr=255#step:5:44

@bennylope bennylope closed this in 571b51e Nov 23, 2023
@a-detiste
Copy link
Author

Ok, part of why I do this is to learn better python3, here clearly don't understand enough of the mater.

@bennylope
Copy link
Owner

@a-detiste that's okay! I sincerely appreciate that you took the effort to tackle the issue.

@a-detiste
Copy link
Author

I will bookmark your changes to see if they also applie to other six-using django packages:

python3-django-dynamic-preferences       2     
python3-django-pglocks                   3     
python3-django-yarnpkg                   3     
python3-django-dbbackup                  7     
python3-django-etcd-settings             7     
python3-django-session-security          7     
python3-django-auto-one-to-one           8     
python3-scrapy-djangoitem                8     
python3-django-bitfield                  9     
python3-django-netfields                 9     
python3-django-shortuuidfield            10    
python3-django-organizations             11    
python3-django-ordered-model             13    
python3-django-cas-server                14    
python3-django-maintenancemode           14    
python3-django-oauth-toolkit             14    
python3-django-wkhtmltopdf               16    
python3-django-environ                   31    
python3-django-horizon                   35    
python3-django-pyscss                    44    
python3-django-q                         138   
python3-django-picklefield               142   
python3-django-compressor                183   
python3-django-guardian                  202   
python3-django-appconf                   357 

@bennylope
Copy link
Owner

All I did was extract from six the function that combined the metaclasses, for what it's worth. Whether it's the "best" method is was certainly the most expedient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants