refactor: add a static on the function for better id of comp type

benox3 · May 7, 2019 · 4524518 · 4524518
1 parent 4c76ec2
commit 4524518
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/src/DataScroller.tsx b/src/DataScroller.tsx
@@ -23,10 +23,8 @@ const getColumns = (node: React.ReactNode) => {
 
       if (
         column.props &&
-        (column.type === Column ||
-          // This is necessary for HMR
-          // @ts-ignore
-          column.type.displayName === 'Column')
+        // @ts-ignore
+        column.type.__Column__
       ) {
         return [...acc, column.props];
       }
@@ -67,10 +65,8 @@ const getColumnsAndGroups = (
       }
 
       if (
-        elementChild.type === Group ||
-        // This is necessary for HMR
         // @ts-ignore
-        elementChild.type.displayName === 'Group'
+        elementChild.type.__Group__
       ) {
         return {
           ...acc,

diff --git a/src/components/Column/Column.tsx b/src/components/Column/Column.tsx
@@ -13,3 +13,6 @@ export type Props = {
 export default function Column(props: Props) {
   return null;
 }
+
+// Used for identifying the component type when iterating through children
+Column.__Column__ = true;
diff --git a/src/components/Group/Group.tsx b/src/components/Group/Group.tsx
@@ -10,3 +10,6 @@ export type Props = {
 export default function Group({ children, headerRenderer, groupData }: Props) {
   return null;
 }
+
+// Used for identifying the component type when iterating through children
+Group.__Group__ = true;