Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): type fixes #4182

Merged
merged 3 commits into from
Oct 12, 2023
Merged

fix(client): type fixes #4182

merged 3 commits into from
Oct 12, 2023

Conversation

sauyon
Copy link
Contributor

@sauyon sauyon commented Sep 14, 2023

Depends on #4181.

Review the second commit if you want to review this now.

@sauyon sauyon requested a review from a team as a code owner September 14, 2023 00:18
@sauyon sauyon requested review from parano and removed request for a team September 14, 2023 00:18
@sauyon sauyon force-pushed the type-fixesc branch 2 times, most recently from ec36b45 to 3185d2d Compare September 14, 2023 00:24
@pep8speaks
Copy link

Hello @sauyon! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 85:80: E501 line too long (85 > 79 characters)

Line 47:80: E501 line too long (93 > 79 characters)
Line 80:80: E501 line too long (93 > 79 characters)
Line 111:80: E501 line too long (93 > 79 characters)
Line 141:80: E501 line too long (81 > 79 characters)
Line 142:80: E501 line too long (81 > 79 characters)
Line 146:80: E501 line too long (80 > 79 characters)

@larme larme added this to the 1.1.7 milestone Oct 10, 2023
@aarnphm aarnphm merged commit ab59b8d into bentoml:main Oct 12, 2023
@aarnphm aarnphm deleted the type-fixesc branch October 12, 2023 09:32
@aarnphm aarnphm mentioned this pull request Oct 12, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants