Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use httpx for usage tracking #4228

Merged
merged 4 commits into from
Oct 12, 2023
Merged

Conversation

sauyon
Copy link
Contributor

@sauyon sauyon commented Oct 10, 2023

No description provided.

@sauyon sauyon requested a review from a team as a code owner October 10, 2023 02:20
@sauyon sauyon requested review from ssheng and removed request for a team October 10, 2023 02:20
@pep8speaks
Copy link

pep8speaks commented Oct 10, 2023

Hello @sauyon! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 125:80: E501 line too long (87 > 79 characters)

Comment last updated at 2023-10-10 02:20:39 UTC

sauyon and others added 2 commits October 9, 2023 21:05
Co-Authored-By: Judah Rand <17158624+judahrand@users.noreply.github.com>
@aarnphm aarnphm mentioned this pull request Oct 12, 2023
5 tasks
Signed-off-by: Aaron <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm merged commit 2ae6a51 into bentoml:main Oct 12, 2023
24 of 39 checks passed
@aarnphm aarnphm deleted the httpx-analytics branch October 12, 2023 17:55
@sauyon
Copy link
Contributor Author

sauyon commented Oct 20, 2023

I think this PR broke CI @aarnphm going to revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants