Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Places not taking part included #27

Open
beny23 opened this issue Aug 18, 2020 · 4 comments
Open

Places not taking part included #27

beny23 opened this issue Aug 18, 2020 · 4 comments

Comments

@beny23
Copy link
Owner

beny23 commented Aug 18, 2020

From the app feedback

D522161A-6CED-4CBB-95B7-7030071FFE27

@exussum12
Copy link
Collaborator

Think it's related to the other comment of chains ?

Probably worth filtering out some more from the FSA data to just ones classed as pubs or restaurants ? It's a shame there's no more detail :(

@beny23
Copy link
Owner Author

beny23 commented Aug 19, 2020

Totally agree, I am wondering whether to restrict the filter_chain to also take the business type into account and only use restaurants/cafes etc - better to err on the side of caution!

@exussum12
Copy link
Collaborator

exussum12 commented Aug 19, 2020

May be worth comparing to this ?

https://github.com/fryford/eatouttohelpout/blob/master/source-information/SOURCES.md

They have scraped each chains websites to get the list, Ive compared to some of the missing ones picked up by the open PR and they appear in the list above. so it seems fairly accurate

@beny23
Copy link
Owner Author

beny23 commented Aug 20, 2020

That's a brilliant find!

beny23 added a commit that referenced this issue Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants